| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 27/49] xfs: consolidate extent swap code |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Fri, 26 Jul 2013 16:16:55 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1374215120-7271-28-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-28-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 07/19/13 01:24, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> So we don't need xfs_dfrag.h in userspace anymore, move the extent swap ioctl structure definition to xfs_fs.h where most of the other ioctl structure definitions are. Now that we don't need separate files for extent swapping, separate the basic file descriptor checking code to xfs_ioctl.c, and the code that does the extent swap operation to xfs_bmap_util.c. This cleanly separates the user interface code from the physical mechanism used to do the extent swap. Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> --- Looks good. Only change is xfs_swapext() is rename xfs_ioc_swapext() when moved to xfs_ioctl.c. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| Previous by Date: | Re: understanding speculative preallocation, Jason Rosenberg |
|---|---|
| Next by Date: | Re: how to use fstrim?, Eric Sandeen |
| Previous by Thread: | [PATCH 27/49] xfs: consolidate extent swap code, Dave Chinner |
| Next by Thread: | [PATCH 39/49] xfs: Get rid of all XFS_XXX_LOG_RES() macro, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |