[Top] [All Lists]

Re: [PATCH 26/49] xfs: consolidate xfs_utils.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 26/49] xfs: consolidate xfs_utils.c
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 26 Jul 2013 15:16:25 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374215120-7271-27-git-send-email-david@xxxxxxxxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-27-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/19/13 01:24, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

There are a few small helper functions in xfs_util, all related to
xfs_inode modifications. Move them all to xfs_inode.c so all
xfs_inode operations are consiolidated in the one place.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>

As noted before, a xfs_utils.h did not get removed from xfs_inode_fork.c

Clean moves with some typedef to struct conversion on the moved function prototypes.

With the removal of xfs_utils.h from xfs_inode_fork.c considered this

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>