[Top] [All Lists]

Re: [PATCH] xfstests: exit out if _scratch_mount fails

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: exit out if _scratch_mount fails
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Fri, 26 Jul 2013 12:25:58 -0400
Cc: Ben Myers <bpm@xxxxxxx>, Josef Bacik <jbacik@xxxxxxxxxxxx>, <linxu-btrfs@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1374855962; bh=3tx0b7szsSYte7dPpqaFa/nWDjd3+C3qm7oFGfNbp2A=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Gx+dhXrA29KGe939Fo04EMHACDyXw65RUcDw6cIFkNu/55HX+bXkDrZosWaSnW6y3 j5nhvSph9ja5Z7/fxFQnNCII5chf/YeVSp8SMVcVE6YUXWkSZAZEf+8y6ygs5LNnrF HHzuSc0XgPSYSfQkhD7ip6IUwIWclXM7KlKHvUJc=
In-reply-to: <51F2A091.3010407@xxxxxxxxxxx>
References: <1373396847-7975-1-git-send-email-jbacik@xxxxxxxxxxxx> <20130726161235.GK3111@xxxxxxx> <51F2A091.3010407@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2011-07-01)
On Fri, Jul 26, 2013 at 11:15:13AM -0500, Eric Sandeen wrote:
> On 7/26/13 11:12 AM, Ben Myers wrote:
> > Hey Josef,
> > 
> > On Tue, Jul 09, 2013 at 03:07:27PM -0400, Josef Bacik wrote:
> >> I test some of the different mkfs options for btrfs, one set doesn't work
> >> properly with small file systems, so the fs won't mount.  This is fine 
> >> from a
> >> btrfs point of view, but tests that fail to mount the scratch fs will run
> >> anyway, so if it's a "fill the fs" sort of test this will wreak havoc.  To 
> >> fix
> >> this just error out of _scratch_mount fails.  Thanks,
> >>
> >> Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
> > 
> > I noticed that this change causes dmapi tests to try to be run on systems 
> > that
> > don't have dmapi supported, and they fail.  Have you seen this?
> > 
> > Thanks,
> >     Ben
> I haven't tested either way, but does:
>      _mount -t $FSTYP `_scratch_mount_options $*` || _fail "Scratch mount 
> failed"
> work any better?

Well thats cleaner but I'm not sure why this patch is making that happen.  I
don't have dmapi on my main box (at least afaik) and I've not had that sort of
issue running with this patch.  Thanks,


<Prev in Thread] Current Thread [Next in Thread>