xfs
[Top] [All Lists]

Re: [PATCH 03/48] libxfs: add crc format changes to generic btrees

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 03/48] libxfs: add crc format changes to generic btrees
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 26 Jul 2013 10:22:26 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130726003953.GA21982@dastard>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-4-git-send-email-david@xxxxxxxxxxxxx> <20130723182648.GI3111@xxxxxxx> <20130725004821.GC11222@dastard> <20130725171509.GZ3111@xxxxxxx> <20130726003953.GA21982@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
Dave,

On Fri, Jul 26, 2013 at 10:39:53AM +1000, Dave Chinner wrote:
> On Thu, Jul 25, 2013 at 12:15:09PM -0500, Ben Myers wrote:
> > On Thu, Jul 25, 2013 at 10:48:21AM +1000, Dave Chinner wrote:
> > > On Tue, Jul 23, 2013 at 01:26:48PM -0500, Ben Myers wrote:
> > > > On Fri, Jun 07, 2013 at 10:25:26AM +1000, Dave Chinner wrote:
> > > > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > > > > 
> > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > > > 
> > > > This patch mostly corresponds to commit ee1a47ab0e, and in some areas 
> > > > it is
> > > > equivalent but slightly different.  There are some other things in here 
> > > > too:
> > > > 
> > > > * Addition of XFS_BUF_DADDR_NULL
> > > > * rename of b_blkno to b_bn in struct xfs_buf
> > > > * rename of b_fsprivate to b_fspriv in struct xfs_buf
> > > > * addition of uuid_copy and uuid_equal, and libuuid to build
> > > > 
> > > > It all looks fine to me, except as below:
> > > 
> > > I think you'll find they are fixed up in later patches in the
> > > series.
> > > 
> > > Indeed, I think it's a little late to asking for these patches to be
> > > changed, considering that making significant changes to these first
> > > few patches will mean that I have to rebase a 100 or so subsequent
> > > patches.
> > 
> > You are mistaken...
> 
> Mistaken about what, exactly?

You are mistaken to assume that I will not require changes be made to patches
at the beginning of your series regardless of the quantity of work you have on
top.  Pulling these into crc-dev without review did not imply that these
patches are set in concrete.

Having said that, I'm not doing these reviews to make your life difficult.
Unless we find something egregious (such as the mismatched commit message in
patch 7), I have no objection to taking the approach that minor issues can be
fixed at the end of the series.

-Ben

<Prev in Thread] Current Thread [Next in Thread>