| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 29/49] xfs: kill __KERNEL__ check for debug code in allocation code |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Fri, 26 Jul 2013 10:07:11 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1374215120-7271-30-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-30-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 07/19/13 01:25, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> Userspace running debug builds is relatively rare, so there's need to special case the allocation algorithm code coverage debug switch. As it is, userspace defines random numbers to 0, so invert the logic of the switch so it is effectively a no-op in userspace. This kills another couple of __KERNEL__ users. Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> --- No functional change for the kernel. skipping the first allocation algorithm is still 50% for debug kernels. Change is for user space. Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 30/49] xfs: remove __KERNEL__ from debug code, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH] xfstest: add a test for btrfs device replace operation, Eric Sandeen |
| Previous by Thread: | [PATCH 29/49] xfs: kill __KERNEL__ check for debug code in allocation code, Dave Chinner |
| Next by Thread: | [PATCH 06/49] xfs: separate icreate log format definitions from xfs_icreate_item.h, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |