Re: [PATCH 33/49] xfs: move kernel specific type definitions to xfs.h

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 33/49] xfs: move kernel specific type definitions to xfs.h
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Fri, 26 Jul 2013 08:51:19 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1374215120-7271-34-git-send-email-david@xxxxxxxxxxxxx>
References:	<1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-34-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 07/19/13 01:25, Dave Chinner wrote:

From: Dave Chinner<dchinner@xxxxxxxxxx>

xfs_types.h is shared with userspace, so having kernel specific
types defined in it is problematic. Move all the kernel specific
defines to xfs_linux.h so we can remove the __KERNEL__ guards from
xfs_types.h

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 48/49] xfs: Add read-only support for dirent filetype field, (continued) Re: [PATCH 48/49] xfs: Add read-only support for dirent filetype field, Mark Tinguely [PATCH 25/49] xfs: consolidate xfs_rename.c, Dave Chinner Re: [PATCH 25/49] xfs: consolidate xfs_rename.c, Mark Tinguely [PATCH 24/49] xfs: kill xfs_vnodeops.[ch], Dave Chinner Re: [PATCH 24/49] xfs: kill xfs_vnodeops.[ch], Mark Tinguely Re: [PATCH 24/49] xfs: kill xfs_vnodeops.[ch], Dave Chinner Re: [PATCH 24/49] xfs: kill xfs_vnodeops.[ch], Mark Tinguely [PATCH 13/49] xfs: move unrealted definitions out of xfs_inode.h, Dave Chinner Re: [PATCH 13/49] xfs: move unrealted definitions out of xfs_inode.h, Mark Tinguely [PATCH 33/49] xfs: move kernel specific type definitions to xfs.h, Dave Chinner Re: [PATCH 33/49] xfs: move kernel specific type definitions to xfs.h, Mark Tinguely <= [PATCH 21/49] xfs: create xfs_bmap_util.[ch], Dave Chinner Re: [PATCH 21/49] xfs: create xfs_bmap_util.[ch], Mark Tinguely [PATCH 45/49] xfs: avoid CIL allocation during insert, Dave Chinner Re: [PATCH 45/49] xfs: avoid CIL allocation during insert, Mark Tinguely [PATCH 20/49] xfs: introduce xfs_sb.c for sharing with libxfs, Dave Chinner Re: [PATCH 20/49] xfs: introduce xfs_sb.c for sharing with libxfs, Mark Tinguely Re: [PATCH 20/49] xfs: introduce xfs_sb.c for sharing with libxfs, Dave Chinner [PATCH 15/49] xfs: move getdents code into it's own file, Dave Chinner Re: [PATCH 15/49] xfs: move getdents code into it's own file, Brian Foster [PATCH 46/49] xfs: Combine CIL insert and prepare passes, Dave Chinner

Previous by Date:	Re: [PATCH 34/49] xfs: make struct xfs_perag kernel only, Mark Tinguely
Next by Date:	Re: [PATCH 32/49] xfs: xfs_filestreams.h doesn't need __KERNEL__, Mark Tinguely
Previous by Thread:	[PATCH 33/49] xfs: move kernel specific type definitions to xfs.h, Dave Chinner
Next by Thread:	[PATCH 21/49] xfs: create xfs_bmap_util.[ch], Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]