Re: [PATCH 34/49] xfs: make struct xfs

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 34/49] xfs: make struct xfs_perag kernel only
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Fri, 26 Jul 2013 08:32:09 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1374215120-7271-35-git-send-email-david@xxxxxxxxxxxxx>
References:	<1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-35-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 07/19/13 01:25, Dave Chinner wrote:

From: Dave Chinner<dchinner@xxxxxxxxxx>

The struct xfs_perag has many kernel-only definitions in it,
requiring a __KERNEL__ guard so userspace can use it to. Move it to
xfs_mount.h so that it it kernel-only, and let userspace redefine
it's own version of the structure containing only what it needs.
This gets rid of another __KERNEL__ check in the XFS header files.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


moves the xfs_perag structure and adds a comment to why it is moved.

looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 27/49] xfs: consolidate extent swap code, (continued) [PATCH 27/49] xfs: consolidate extent swap code, Dave Chinner Re: [PATCH 27/49] xfs: consolidate extent swap code, Mark Tinguely [PATCH 39/49] xfs: Get rid of all XFS_XXX_LOG_RES() macro, Dave Chinner Re: [PATCH 39/49] xfs: Get rid of all XFS_XXX_LOG_RES() macro, Mark Tinguely [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface, Dave Chinner Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface, Mark Tinguely Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface, Dave Chinner [PATCH 36/49] xfs: Introduce tr_fsyncts to m_reservation, Dave Chinner Re: [PATCH 36/49] xfs: Introduce tr_fsyncts to m_reservation, Mark Tinguely [PATCH 34/49] xfs: make struct xfs_perag kernel only, Dave Chinner Re: [PATCH 34/49] xfs: make struct xfs_perag kernel only, Mark Tinguely <= [PATCH 07/49] xfs: split out on-disk transaction definitions, Dave Chinner Re: [PATCH 07/49] xfs: split out on-disk transaction definitions, Brian Foster [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Dave Chinner Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Mark Tinguely Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Dave Chinner Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Brian Foster [PATCH 47/49] xfs: split the CIL lock, Dave Chinner Re: [PATCH 47/49] xfs: split the CIL lock, Mark Tinguely [PATCH 02/49] xfs: split out inode log item format definition, Dave Chinner Re: [PATCH 02/49] xfs: split out inode log item format definition, Brian Foster

Previous by Date:	Re: [PATCH 16/49] xfs: reshuffle dir2 definitions around for userspace, Brian Foster
Next by Date:	Re: [PATCH 33/49] xfs: move kernel specific type definitions to xfs.h, Mark Tinguely
Previous by Thread:	[PATCH 34/49] xfs: make struct xfs_perag kernel only, Dave Chinner
Next by Thread:	[PATCH 07/49] xfs: split out on-disk transaction definitions, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 34/49] xfs: make struct xfs_perag kernel only