[Top] [All Lists]

Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operat

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 26 Jul 2013 10:24:50 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51F179BE.4040506@xxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-15-git-send-email-david@xxxxxxxxxxxxx> <51F179BE.4040506@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jul 25, 2013 at 02:17:18PM -0500, Mark Tinguely wrote:
> On 07/19/13 01:24, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@xxxxxxxxxx>
> >
> >The only thing remaining in xfs_inode.[ch] are the operations that
> >read, write or verify physical inodes in their underlying buffers.
> >Move all this code to xfs_inode_buf.[ch] and so we can stop sharing
> >xfs_inode.[ch] with userspace.
> >
> >Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> >---
> Bug patches committed in the last couple days make this patch no
> longer current.

Right, which is why I've had to rebase it (yet again). The changes
are minor, though, and shouldn't prevent review of this version of
the patch.

I haven't reposted the new series yet, because I'm waiting on
reviews for the current series to be done and I don't want to have
to continually rebase and repost the series. There is a risk that
every time I do a rebase that I screw something up, so I want to
minimise the number of rebases I have to do.

This is yet another reason why I'd like to see this code reviewed
quickly and committed because I've already rebased it several times
and it's not fun. Repeated rebasing simply because review of slow is
a waste of everyone's time...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>