xfs
[Top] [All Lists]

Re: [PATCH 21/48] xfs: implement extended feature masks

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 21/48] xfs: implement extended feature masks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 26 Jul 2013 10:19:17 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130725220814.GI3111@xxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-22-git-send-email-david@xxxxxxxxxxxxx> <20130725220814.GI3111@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jul 25, 2013 at 05:08:14PM -0500, Ben Myers wrote:
> On Fri, Jun 07, 2013 at 10:25:44AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > The version 5 superblock has extended feature masks for compatible,
> > incompatible and read-only compatible feature sets. Implement the
> > masking and mount-time checking for these feature masks.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> corresponds to commit e721f504cf46a
> 
> > @@ -214,12 +242,6 @@ xfs_mount_validate_sb(
> >             return XFS_ERROR(ENOSYS);
> >     }
> >  
> > -
> > -   if (check_inprogress && sbp->sb_inprogress) {
> > -           xfs_warn(mp, "Offline file system operation in progress!");
> > -           return XFS_ERROR(EFSCORRUPTED);
> > -   }
> > -
> 
> Why did this need to be removed?

Think about it for a minute - it's not valid in userspace. i.e. it's
a kernel-side check to determine if userspace is modifying the
filesystem at the current time.

e.g. mkfs.xfs sets it in the primary superblock to prevent the
kernel mounting the filesystem before mkfs completes. If we leave it
in the userspace code, then mkfs will abort when it rereads the
superblock from disk because it's detected that mkfs is running....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>