xfs
[Top] [All Lists]

Re: [PATCH 21/48] xfs: implement extended feature masks

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 21/48] xfs: implement extended feature masks
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 25 Jul 2013 17:08:14 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-22-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-22-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:44AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The version 5 superblock has extended feature masks for compatible,
> incompatible and read-only compatible feature sets. Implement the
> masking and mount-time checking for these feature masks.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

corresponds to commit e721f504cf46a

> @@ -214,12 +242,6 @@ xfs_mount_validate_sb(
>               return XFS_ERROR(ENOSYS);
>       }
>  
> -
> -     if (check_inprogress && sbp->sb_inprogress) {
> -             xfs_warn(mp, "Offline file system operation in progress!");
> -             return XFS_ERROR(EFSCORRUPTED);
> -     }
> -

Why did this need to be removed?

Other than that this looks fine.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>