xfs
[Top] [All Lists]

Re: [PATCH 19/48] xfs: buffer type overruns blf_flags field

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 19/48] xfs: buffer type overruns blf_flags field
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 25 Jul 2013 16:08:50 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-20-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-20-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:42AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The buffer type passed to log recvoery in the buffer log item
> overruns the blf_flags field. I had assumed that flags field was a
> 32 bit value, and it turns out it is a unisgned short. Therefore
> having 19 flags doesn't really work.
> 
> Convert the buffer type field to numeric value, and use the top 5
> bits of the flags field for it. We currently have 17 types of
> buffers, so using 5 bits gives us plenty of room for expansion in
> future....
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

This corresponds to commit 61fe135c1dde1.

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 19/48] xfs: buffer type overruns blf_flags field, Ben Myers <=