xfs
[Top] [All Lists]

Re: [PATCH 18/48] xfs: add buffer types to directory and attribute buffe

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 18/48] xfs: add buffer types to directory and attribute buffers
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 25 Jul 2013 15:54:41 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-19-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-19-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:41AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Add buffer types to the buffer log items so that log recovery can
> validate the buffers and calculate CRCs correctly after the buffers
> are recovered.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Corresponds to commit d75afeb3d3020.

> diff --git a/libxfs/xfs.h b/libxfs/xfs.h
> index c69dc4a..6bec18e 100644
> --- a/libxfs/xfs.h
> +++ b/libxfs/xfs.h
> @@ -255,6 +255,7 @@ roundup_pow_of_two(uint v)
>  #define      xfs_trans_agflist_delta(tp, d)
>  #define      xfs_trans_agbtree_delta(tp, d)
>  #define xfs_trans_buf_set_type(tp, bp, t)
> +#define xfs_trans_buf_copy_type(dbp, sbp)

Looks like he's not called but needs to be defined to compile.

> diff --git a/libxfs/xfs_dir2_leaf.c b/libxfs/xfs_dir2_leaf.c
> index f00b23c..3d1ec23 100644
> --- a/libxfs/xfs_dir2_leaf.c
> +++ b/libxfs/xfs_dir2_leaf.c

There is probably a change later in the series that makes
xfs_dir3_leaf1_buf_ops not static.

> @@ -232,7 +239,8 @@ xfs_dir3_free_get_buf(
>       if (error)
>               return error;
>  
> -     bp->b_ops = &xfs_dir3_free_buf_ops;;

Oh good.  Got rid of the extra ;

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 18/48] xfs: add buffer types to directory and attribute buffers, Ben Myers <=