xfs
[Top] [All Lists]

Re: [PATCH 12/49] xfs: move inode fork definitions to a new header file

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/49] xfs: move inode fork definitions to a new header file
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 25 Jul 2013 15:40:34 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374215120-7271-13-git-send-email-david@xxxxxxxxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-13-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/19/13 01:24, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The inode fork definitions are a combination of on-disk format
definition and in-memory tracking and manipulation. They are both
shared with userspace, so move them all into their own file so
sharing is easy to do and track.  This removes all inode fork
related information from xfs_inode.h.

Do the same for the all the C code that currently resides in
xfs_inode.c for the same reason.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

summary:

Mostly a move of routines/structures from xfs_inode.c/h to xfs_inode_fork.c/h.

xfs_validate_extents() is no longer a STATIC, as expected.

xfs_iformat() is renamed xfs_iformat_fork().

function declarations in xfs_inode_fork.h have the typedef converted to structs.

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>