xfs
[Top] [All Lists]

Re: [PATCH 16/48] xfs: split remote attribute code out

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 16/48] xfs: split remote attribute code out
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 25 Jul 2013 15:27:06 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-17-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-17-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:39AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Adding CRC support to remote attributes adds a significant amount of
> remote attribute specific code. Split the existing remote attribute
> code out into it's own file so that all the relevant remote
> attribute code is in a single, easy to find place.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Corresponds to commit 95920cd6ce1

> diff --git a/include/xfs_attr_remote.h b/include/xfs_attr_remote.h
> new file mode 100644
> index 0000000..b4be90e
> --- /dev/null
> +++ b/include/xfs_attr_remote.h
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright (c) 2013 Red Hat, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of version 2.1 of the GNU Lesser General Public License
> + * as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it would be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> + *
> + * Further, this software is distributed without any warranty that it is
> + * free of the rightful claim of any third person regarding infringement
> + * or the like.  Any license provided herein, whether implied or
> + * otherwise, applies only to this software file.  Patent licenses, if
> + * any, provided herein do not apply to combinations of this program with
> + * other software, or any other product whatsoever.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this program; if not, write the Free Software
> + * Foundation, Inc., 59 Temple Place - Suite 330, Boston MA 02111-1307,
> + * USA.
> + */

This gpl header is different than the one in the kernel.  Probably fixed later 
in the series.

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 16/48] xfs: split remote attribute code out, Ben Myers <=