xfs
[Top] [All Lists]

Re: [PATCH 13/48] xfs: shortform directory offsets change for dir3 forma

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 13/48] xfs: shortform directory offsets change for dir3 format
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 25 Jul 2013 12:28:49 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-14-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-14-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:36AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Because the header size for the CRC enabled directory blocks is
> larger, the offset of the first entry into a directory block is
> different to the dir2 format. The shortform directory stores the
> dirent's offset so that it doesn't change when moving from shortform
> to block form and back again, and hence it needs to take into
> account the different header sizes to maintain the correct offsets.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

corresponds to commit 6b2647a12a0

xfs_dir2_sf_getdents which is changed in the kernel commit doesn't exist in 
userspace.

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 13/48] xfs: shortform directory offsets change for dir3 format, Ben Myers <=