| To: | Koen De Wit <koen.de.wit@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: fix _mount_ops_filter() to support $TEST_DIR containing -o |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Wed, 24 Jul 2013 18:09:02 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1372801497-3941-1-git-send-email-koen.de.wit@xxxxxxxxxx> |
| References: | <1372801497-3941-1-git-send-email-koen.de.wit@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Tue, Jul 02, 2013 at 11:44:57PM +0200, Koen De Wit wrote: > If multiple mount options are given with multiple -o parameters, > _mount_ops_filter concatenates them by replacing all -o's with a comma > (except for the first -o). > > If $TEST_DIR contains "-o" (e.g. /mnt/test-os/) you get errors like this: > > # ./check generic/002 > mount: mount point /mnt/test,s/ does not exist > common/rc: retrying test device mount with external set > mount: mount point /mnt/test,s/ does not exist > common/rc: could not mount /dev/sdc3 on /mnt/test-os/ > > Fix it by only replacing -o's that are preceded by at least one space. > > Signed-off-by: Koen De Wit <koen.de.wit@xxxxxxxxxx> Reviewed-by: Ben Myers <bpm@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests: make the scratch device for generic/256 slightly larger, Ben Myers |
|---|---|
| Next by Date: | Re: [PATCH] Xfstests/btrfs/308: add snapshot-aware defrag for partial extents testcases, Ben Myers |
| Previous by Thread: | [PATCH] xfstests: fix _mount_ops_filter() to support $TEST_DIR containing -o, Koen De Wit |
| Next by Thread: | Re: swidth in RAID, Peter Grandi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |