xfs
[Top] [All Lists]

Re: [PATCH 08/48] libxfs: add support for crc headers on remote symlinks

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/48] libxfs: add support for crc headers on remote symlinks
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 24 Jul 2013 15:07:45 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:31AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Ok, so this corresponds with commit f948dd76d and commit 19de7351a....


> diff --git a/include/xfs_symlink.h b/include/xfs_symlink.h
> new file mode 100644
> index 0000000..bb21e6a
> --- /dev/null
> +++ b/include/xfs_symlink.h
> @@ -0,0 +1,43 @@
> +/*
> + * Copyright (c) 2012 Red Hat, Inc. All rights reserved.
> + */

Please add the gpl header as you did in the kernel.


> diff --git a/libxfs/Makefile b/libxfs/Makefile
> index 28f71c8..75f365c 100644
> --- a/libxfs/Makefile
> +++ b/libxfs/Makefile
> @@ -17,7 +17,7 @@ CFILES = cache.c init.c kmem.c logitem.c radix-tree.c 
> rdwr.c trans.c util.c \
>       xfs_dir2.c xfs_dir2_leaf.c xfs_attr_leaf.c xfs_dir2_block.c \
>       xfs_dir2_node.c xfs_dir2_data.c xfs_dir2_sf.c xfs_bmap.c \
>       xfs_mount.c xfs_rtalloc.c xfs_trans.c xfs_attr.c \
> -     crc32.c
> +     crc32.c xfs_symlink.c
>  
>  CFILES += $(PKG_PLATFORM).c
>  PCFILES = darwin.c freebsd.c irix.c linux.c
> diff --git a/libxfs/xfs_symlink.c b/libxfs/xfs_symlink.c
> new file mode 100644
> index 0000000..e018abc
> --- /dev/null
> +++ b/libxfs/xfs_symlink.c
> @@ -0,0 +1,154 @@
> +/*
> + * Copyright 2013 Red Hat, Inc.
> + * All rights reserved.
> + */

Here too.

Else, this looks fine.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 08/48] libxfs: add support for crc headers on remote symlinks, Ben Myers <=