[Top] [All Lists]

Re: [PATCH 44/49] xfs: Reduce allocations during CIL insertion

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 44/49] xfs: Reduce allocations during CIL insertion
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Tue, 23 Jul 2013 17:44:41 -0400
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=V/Gr3sNnmpE4L2JuWDoFGnDl1cX1+4lK9H7URKiAfzg=; b=RBqTnn5cNOhVGt1bZVXCZbBbRWJB8YBIIS4+fzXAGszjNcZQftk4ONmF6ZM4yUFdu8 9TzfMvSx1Sx7SW/kWkxv1yGPRUl55k76jPB/FYhTLuUuTpz5ulPiVLCt199g0T9eRdc7 +eGGTWyrCj+2o69Y8TPF3tmHpKpavjtsatBZ2hI5LAV94NMyn9UDx7fqw1/s+zDTd5dG 9mCNC9gEHf7Gcn01Vjo41xtQPcft2ATY2OfnLLLDQzKUst5Uu5++TZHfhtnYanvkZenA 2VLXlAsYffvCG0jK0MwLXKlr1tWUACv1Q99h+69MZm9RdwCCQV8jP+JPGBpa3WBxlJP8 UjFw==
In-reply-to: <51EEF26F.5040001@xxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-45-git-send-email-david@xxxxxxxxxxxxx> <51EEF26F.5040001@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
On 07/23/2013 05:15 PM, Mark Tinguely wrote:
> On 07/19/13 01:25, Dave Chinner wrote:
>> From: Dave Chinner<dchinner@xxxxxxxxxx>
>> Now that we have the size of the object before the formatting pass
>> is called, we can allocation the log vector and it's buffer in a
>> single allocation rather than two separate allocations.
>> Store the size of the allocated buffer in the log vector so that
>> we potentially avoid allocation for future modifications of the
>> object.
>> While touching this code, remove the IOP_FORMAT definition.
>> Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> Looks good.
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

I'd like to register a gentle "test this well" protest on this patch. 
While trying to figure out the origin of an unrelated lockdep, I 
tried to copy 3 kernel gits from one 2k non-CRC XFS filesystem to 
another one.  With at least this patch used, the cp operation stops, 
leading to not-umountable, not-syncable filesystems.  It might be 
while copying the 2nd git, or the 3rd git, while copying header files, 
or while copying those large *.pack files, but it will happen 

A bisect of the issue ends on this patch, but its removal means that 
45_49 and 46_49 cannot be applied without good knowledge of the code 
to be patched.

This one's on me for not being able to get good information to Dave. 
If I can find a way to get trace-cmd to pipe over ssh or something 
like that, then maybe there's a chance to make a file that `trace-cmd 
report` can read.  Previous attempts to save to different filesystems 
or save over NFS and CIFS have all failed.  Will keep trying...

For diagnosing this patch, is there an effective trace that is rather 
small?  And would you need more than just the XFS events?



<Prev in Thread] Current Thread [Next in Thread>