[Top] [All Lists]

Re: [PATCH 00/49] xfsprogs: patches for crc-dev branch

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 00/49] xfsprogs: patches for crc-dev branch
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Tue, 23 Jul 2013 17:02:25 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=JUtynoC930wjyhTyeCIkWcattKqjaEevkiKswT8WMYU=; b=RXHwrACfOOJX7HZciSuzvm32gqt6HqyZwqEzxT49gbHbzCxoGdcz15iXGZGWBQWCFg IqYf5MIBWZlFMCD9M2JbrQAPH7u9PShQY+Ma5hx3Favt6G8UngnRHsnoAitpY6yLK7HX YNRwjhKFZT1bRRnDT/LVz7spSgcTg6UjdrEu1U7E+vfJob0jv94KWqcO0cMT9Ri+CTOC Isev4KTx/qrW9Q58JcnQQq4BEA3a8OGf9+FPy796llA8u0m6itZcAh9Ra0idxNLczoZx Ul798ypu84KZu2n3hC1XTfqDWWruD3JG/IIFX1UYI0IZJNpqFoKLHJzzkBYz5pz/D48j dv7Q==
In-reply-to: <20130723044450.GG19986@dastard>
References: <1374216324-8781-1-git-send-email-david@xxxxxxxxxxxxx> <51EB80DB.80602@xxxxxxxxx> <20130722233240.GC19986@dastard> <51EDFA5A.7070402@xxxxxxxxx> <20130723044450.GG19986@dastard>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
On 07/23/2013 12:44 AM, Dave Chinner wrote:
> On Mon, Jul 22, 2013 at 11:36:58PM -0400, Michael L. Semon wrote:
>> On 07/22/2013 07:32 PM, Dave Chinner wrote:
>>> On Sun, Jul 21, 2013 at 02:34:03AM -0400, Michael L. Semon wrote:
>>>> On 07/19/2013 02:44 AM, Dave Chinner wrote:
>>>>> Comments, thoughts, flames?
>>>> I was hoping that I could use this 3.12 patchset with a 3.11.0-rc 
>>>> kernel, but the xfstests look like a disaster by going that way.  
>>> We'll, if you don't have all the filtering patches that I posted a
>>> while back it'll make quite a mess with all the experimental
>>> warnings mkfs and repair emit, and the xfs_db tests that modify
>>> filesystem structures will all also fail...
>> I've been slacking on xfstests updates.  The problem may exist 
>> between keyboard and chair, though:  I was trying to copy a merged 
>> xfsprogs from one PC to another, then build everything from `make 
>> distclean` after deleting /usr/include/xfs.  Something must have 
>> gone wrong...won't be the first time...
>>> I'll repost them later today...
>> I'll take this patchset home and see if any of them were not 
>> committed to the xfsprogs git:
>> http://oss.sgi.com/archives/xfs/2013-06/msg00217.html
>> Is this the correct patchset?
> Yeah, that's it, thugh I have a more recent version of it locally...
> Cheers,
> Dave.

Thanks.  After applying this patchset and compiling dmapi, xfsprogs, 
xfsdump, and xfstests around in circles several times, it looks 
rather sane now.  Two issues remain, one reproduced on another PC:

1) The earlier worries about dmapi and hole punching comes from the 
results of xfs/145 being run.  It hasn't been that long, but I've 
forgotten the last time xfstests gave messages like "[not run] DMAPI 
modules not loaded."  dmapi is installed as a prerequisite; I have 
precisely zero knowledge of what happens when it is enabled.

2) There are two PCs: the one being discussed here, and the all-3.12 
setup that is in mid-bisect.  For CRC filesystems made by the new 
mkfs.xfs for the 3.11.0-rc and 3.10.0+ mid-bisect kernels, attempts 
to mount them fail with a dmesg like this (by memory)...

XFS(sdb6): ... unknown incompatible features (0x1) detected ...
Filesystem can not be safely mounted by this kernel.

Is there an extra flag that can be passed to mkfs.xfs for the sake 
of older CRC-capable kernels?  FWIW, both PCs could still mount 
CRC-enabled XFS filesystems made during the kernel 3.10-rc cycle.

Thanks again!


<Prev in Thread] Current Thread [Next in Thread>