[Top] [All Lists]

Re: [PATCH 05/48] xfsprogs: Support new AGFL format

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/48] xfsprogs: Support new AGFL format
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 23 Jul 2013 14:10:43 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:28AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> With the addition of CRCs to the filesystem format, the AGFL has a
> new format structure definition. Existing code that pulls freelist
> blocks out via dereferencing agfl->agfl_bno no longer works as the
> location of the free list is now variable depending on the disk
> format in use.
> Hence all the users of agfl_bno need ot be converted to extract the
> location of the first free list entry from the AGFL and grab entries
> relative to that first entry. It's a simple change, but needs to be
> made in several places as there is very little code reuse within and
> between the different utilities in xfsprogs.

Looks fine.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 05/48] xfsprogs: Support new AGFL format, Ben Myers <=