xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: di_flushiter considered harmful

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH v2] xfs: di_flushiter considered harmful
From: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
Date: Tue, 23 Jul 2013 17:56:15 +0200
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple; d=mail.ud10.udmedia.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=beta; bh=FjvB5pwe58xY5lyUMHj94qpmGd rUqEJZezwdyninfhs=; b=r3la0Eg3Ewmxn6ViqzZuT1Qj+2vHOV4OS8VXuONR+G nr3VjN5qeOww4lLeePBtTTMXu6eOeJz6wpuomC1xbb52opeDGZWi0LSs8gZDTmgt 9QG6efL86cQ2SOVI/AAvn466Y4QvCHIZeBFVMo77zWX8+OPuZSxXOHx2GGNa3BSs o=
In-reply-to: <20130723150724.GH3111@xxxxxxx>
References: <1374488304-13044-1-git-send-email-david@xxxxxxxxxxxxx> <20130722110732.GA365@x4> <51ED4471.7050708@xxxxxxx> <20130722151542.GB365@x4> <51ED8C73.50306@xxxxxxx> <20130723104259.GB360@x4> <20130723150724.GH3111@xxxxxxx>
On 2013.07.23 at 10:07 -0500, Ben Myers wrote:
> Hi Markus,
> 
> On Tue, Jul 23, 2013 at 12:42:59PM +0200, Markus Trippelsdorf wrote:
> > On 2013.07.22 at 14:48 -0500, Mark Tinguely wrote:
> > > On 07/22/13 10:15, Markus Trippelsdorf wrote:
> > > > On 2013.07.22 at 09:40 -0500, Mark Tinguely wrote:
> > > >> On 07/22/13 06:07, Markus Trippelsdorf wrote:
> > > >>> On 2013.07.22 at 20:18 +1000, Dave Chinner wrote:
> > > >> It seems to me that since we cannot fix this for inode 1/2, then 
> > > >> besides
> > > >> this patch we have to revert patch cca9f93a52d and make it inode 3+ /
> > > >> superblock 5+ (crc) dependent.
> > > >
> > > > Which is exactly what the hunk I've posted does.
> > > >
> > > > Here's the combined patch:
> > > 
> > > Following Dave's instruction to recreate this problem, your patch works 
> > > with an inode 2 and inode 3 (once I remembered to load the module before 
> > > recovery). Dave's patch was successful on inode 3 - again after I 
> > > remembered to load the module before recovery.
> > > 
> > > Whomever makes the formal patch, consider it reviewed-by me.
> > 
> > To get this patch to Linus ASAP, here's the combined patch again. 
> > Please apply.
> > Thanks.
> 
> I'd prefer to have Dave take another look at the combined patch before pulling
> this in.  Even so, we shouldn't have any trouble getting this into -rc3.

Ok, understood. I'll let Dave handle the rest. 

BTW the comment above xfs_iread() probably needs an update, too.

-- 
Markus

<Prev in Thread] Current Thread [Next in Thread>