[Top] [All Lists]

Re: [PATCH 41/49] xfs: Add xfs_log_rlimit.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 41/49] xfs: Add xfs_log_rlimit.c
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 23 Jul 2013 10:15:29 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374215120-7271-42-git-send-email-david@xxxxxxxxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-42-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/19/13 01:25, Dave Chinner wrote:
From: Jie Liu<jeff.liu@xxxxxxxxxx>

Add source files for xfs_log_rlimit.c The new file is used for log
size calculations and validation shared with userspace.

[dchinner: xfs_log_calc_max_attrsetm_res() does not modify the
tr_attrsetm reservation, just calculates the maximum. ]

[dchinner: rework loop in xfs_log_get_max_trans_res() ]

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>

+       if (lsunit)
+               min_logblks = roundup(BTOBB(max_logres), lsunit) + 2 * lsunit;
+       else
+               min_logblks = BTOBB(max_logres);

^^ The space is not really needed when using the below multiplier, but add the 2 * BBSIZE size just to be consistent?

+       min_logblks *= XFS_MIN_LOG_FACTOR;

^^ okay, a 3 times multiplier of the max transaction and an additional log stripe unit padding will more than make up for all my CIL/CTX concerns.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>