[Top] [All Lists]

Re: [PATCH] xfs: Start using pquotaino from the superblock.

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: Start using pquotaino from the superblock.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 23 Jul 2013 09:50:58 +1000
Cc: XFS mailing list <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374273362.8941.2086.camel@xxxxxxxxxxxxxxxxxx>
References: <1374273362.8941.2086.camel@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jul 19, 2013 at 05:36:02PM -0500, Chandra Seetharaman wrote:
> Change from the previous version:
> Addressed Ben's comments
>  - removed unnecessary sb_gquotino == NULLFSINO check in
>    xfs_sb_quota_to_disk()
>  - Changed the fs_quota_stat logic to not fail with EINVAL if
>    both gquota and pquota are available. Instead, fill fs_quota_stat
>    only with gquota information.
> ----
> Start using pquotino and define a macro to check if the
> superblock has pquotino.
> Keep backward compatibilty by alowing mount of older superblock
> with no separate pquota inode.
> Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

Chandra, now that this has been comitted, can you make sure that
the userspace tools handle the separate pquota inode correctly (i.e.
reapir, db, etc). You'll probably be best to work from the crc-dev
branch of the xfsprogs tree...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>