xfs
[Top] [All Lists]

Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 23 Jul 2013 09:37:52 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51ED3351.5010304@xxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-39-git-send-email-david@xxxxxxxxxxxxx> <51ED3351.5010304@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 22, 2013 at 08:27:45AM -0500, Mark Tinguely wrote:
> On 07/19/13 01:25, Dave Chinner wrote:
> >From: Jie Liu<jeff.liu@xxxxxxxxxx>
> >
> >With the new xfs_trans_res structure has been introduced, the log
> >reservation size, log count as well as log flags are pre-initialized
> >at mount time.  So it's time to refine xfs_trans_reserve() interface
> >to be more neat.
> >
> >Also, introduce a new helper M_RES() to return a pointer to the
> >mp->m_resv structure to simplify the input.
> >
> >Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
> >Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> >---
> 
> 
> >+/* shorthand way of accessing reservation structure */
> >+#define M_RES(mp)   (&(mp)->m_resv)
> 
> Not a fan of this define- it does not buy much savings in text and clarity.
> 
> Beside my anti-shouty rant, the patch looks good.

It's designed to be similar to XFS_I, VFS_I and XFS_M. i.e. short,
unique, obviously correct and easy to type. I can change it
if you want - I couldn't really think up a better name...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>