xfs
[Top] [All Lists]

Re: [PATCH] xfs: Start using pquotaino from the superblock.

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: Start using pquotaino from the superblock.
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 22 Jul 2013 14:52:38 -0500
Cc: XFS mailing list <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374273362.8941.2086.camel@xxxxxxxxxxxxxxxxxx>
References: <1374273362.8941.2086.camel@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jul 19, 2013 at 05:36:02PM -0500, Chandra Seetharaman wrote:
> Change from the previous version:
> Addressed Ben's comments
>  - removed unnecessary sb_gquotino == NULLFSINO check in
>    xfs_sb_quota_to_disk()
>  - Changed the fs_quota_stat logic to not fail with EINVAL if
>    both gquota and pquota are available. Instead, fill fs_quota_stat
>    only with gquota information.
> ----
> 
> Start using pquotino and define a macro to check if the
> superblock has pquotino.
> 
> Keep backward compatibilty by alowing mount of older superblock
> with no separate pquota inode.
> 
> Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

Looks good!

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied.  As much as I'd like to send this in a pull request for -rc3, IMO this
is the sort of material that is most appropriate for a merge window.  I think
we'd better wait for 3.12-rc1 merge window to open.  Sorry about that.

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>