xfs
[Top] [All Lists]

Re: Subject: [PATCH v2] xfs: Initialize all quota inodes to be NULLFSINO

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: Subject: [PATCH v2] xfs: Initialize all quota inodes to be NULLFSINO
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 22 Jul 2013 14:08:44 -0500
Cc: XFS mailing list <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374273175.8941.2079.camel@xxxxxxxxxxxxxxxxxx>
References: <1374273175.8941.2079.camel@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jul 19, 2013 at 05:32:55PM -0500, Chandra Seetharaman wrote:
> Change from previous version:
>  - Added the additional comments that Dave wanted.
> 
> -------------
> mkfs doesn't initialize the quota inodes to NULLFSINO as it does for the
> other internal inodes. This leads to two in-core values (0 and NULLFSINO)
> to be checked against, to make sure if a quota inode is valid.
> 
> Solve that problem by initializing the in-core values of all quotaino
> values to NULLFSINO if they are 0 in the disk.
> 
> Note that these values are not written back to on-disk superblock unless
> some quota is enabled on the filesystem. Even in that case sb_pquotino is
> written to disk only if the on-disk superblock supports pquotino
> 
> Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied.

<Prev in Thread] Current Thread [Next in Thread>