Re: [PATCH 42/49] xfs: Validate log space at mount time

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 42/49] xfs: Validate log space at mount time
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Mon, 22 Jul 2013 08:55:44 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1374215120-7271-43-git-send-email-david@xxxxxxxxxxxxx>
References:	<1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-43-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 07/19/13 01:25, Dave Chinner wrote:

From: Jie Liu<jeff.liu@xxxxxxxxxx>

Validate log space during log mount stage, the underlying function
will drop a warning message via syslog in critical level if the log
space is too small or too large.

[ dchinner: For CRC enable filesystems, abort the mounting of the
filesystem as mkfs should never make a log too small for the given
filesystem configuration. ]

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 06/49] xfs: separate icreate log format definitions from xfs_icreate_item.h, (continued) Re: [PATCH 06/49] xfs: separate icreate log format definitions from xfs_icreate_item.h, Brian Foster [PATCH 04/49] xfs: split out inode log item format definition, Dave Chinner Re: [PATCH 04/49] xfs: split out inode log item format definition, Brian Foster [PATCH 10/49] xfs: sync minor header differences needed by userspace., Dave Chinner Re: [PATCH 10/49] xfs: sync minor header differences needed by userspace., Brian Foster [PATCH 08/49] xfs: introduce xfs_rtalloc_defs.h, Dave Chinner Re: [PATCH 08/49] xfs: introduce xfs_rtalloc_defs.h, Brian Foster [PATCH 01/49] xfs: separate out log format definitions, Dave Chinner Re: [PATCH 01/49] xfs: separate out log format definitions, Brian Foster [PATCH 42/49] xfs: Validate log space at mount time, Dave Chinner Re: [PATCH 42/49] xfs: Validate log space at mount time, Mark Tinguely <= Re: [PATCH 42/49] xfs: Validate log space at mount time, Dave Chinner [PATCH 03/49] xfs: split out buf log item format definitions, Dave Chinner Re: [PATCH 03/49] xfs: split out buf log item format definitions, Brian Foster [PATCH 40/49] xfs: Refactor xfs_ticket_alloc() to extract a new helper, Dave Chinner Re: [PATCH 40/49] xfs: Refactor xfs_ticket_alloc() to extract a new helper, Mark Tinguely [PATCH 09/49] xfs: introduce xfs_quota_defs.h, Dave Chinner Re: [PATCH 09/49] xfs: introduce xfs_quota_defs.h, Brian Foster [PATCH 30/49] xfs: remove __KERNEL__ from debug code, Dave Chinner Re: [PATCH 30/49] xfs: remove __KERNEL__ from debug code, Mark Tinguely [PATCH 26/49] xfs: consolidate xfs_utils.c, Dave Chinner

Previous by Date:	Re: [PATCH 40/49] xfs: Refactor xfs_ticket_alloc() to extract a new helper, Mark Tinguely
Next by Date:	hi, rossina . faiwa
Previous by Thread:	[PATCH 42/49] xfs: Validate log space at mount time, Dave Chinner
Next by Thread:	Re: [PATCH 42/49] xfs: Validate log space at mount time, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]