Re: [PATCH 38/49] xfs: refactor xfs_trans

xfs

Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Mon, 22 Jul 2013 08:27:45 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1374215120-7271-39-git-send-email-david@xxxxxxxxxxxxx>
References:	<1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-39-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 07/19/13 01:25, Dave Chinner wrote:

From: Jie Liu<jeff.liu@xxxxxxxxxx>

With the new xfs_trans_res structure has been introduced, the log
reservation size, log count as well as log flags are pre-initialized
at mount time.  So it's time to refine xfs_trans_reserve() interface
to be more neat.

Also, introduce a new helper M_RES() to return a pointer to the
mp->m_resv structure to simplify the input.

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

+/* shorthand way of accessing reservation structure */
+#define M_RES(mp)      (&(mp)->m_resv)


Not a fan of this define- it does not buy much savings in text and clarity.

Beside my anti-shouty rant, the patch looks good.


Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 46/49] xfs: Combine CIL insert and prepare passes, (continued) Re: [PATCH 46/49] xfs: Combine CIL insert and prepare passes, Mark Tinguely Re: [PATCH 46/49] xfs: Combine CIL insert and prepare passes, Dave Chinner Re: [PATCH 46/49] xfs: Combine CIL insert and prepare passes, Mark Tinguely [PATCH 41/49] xfs: Add xfs_log_rlimit.c, Dave Chinner Re: [PATCH 41/49] xfs: Add xfs_log_rlimit.c, Mark Tinguely [PATCH 27/49] xfs: consolidate extent swap code, Dave Chinner Re: [PATCH 27/49] xfs: consolidate extent swap code, Mark Tinguely [PATCH 39/49] xfs: Get rid of all XFS_XXX_LOG_RES() macro, Dave Chinner Re: [PATCH 39/49] xfs: Get rid of all XFS_XXX_LOG_RES() macro, Mark Tinguely [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface, Dave Chinner Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface, Mark Tinguely <= Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface, Dave Chinner [PATCH 36/49] xfs: Introduce tr_fsyncts to m_reservation, Dave Chinner Re: [PATCH 36/49] xfs: Introduce tr_fsyncts to m_reservation, Mark Tinguely [PATCH 34/49] xfs: make struct xfs_perag kernel only, Dave Chinner Re: [PATCH 34/49] xfs: make struct xfs_perag kernel only, Mark Tinguely [PATCH 07/49] xfs: split out on-disk transaction definitions, Dave Chinner Re: [PATCH 07/49] xfs: split out on-disk transaction definitions, Brian Foster [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Dave Chinner Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Mark Tinguely Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Dave Chinner

Previous by Date:	Re: [PATCH 37/49] xfs: Make writeid transaction use tr_writeid, Mark Tinguely
Next by Date:	Re: [PATCH 39/49] xfs: Get rid of all XFS_XXX_LOG_RES() macro, Mark Tinguely
Previous by Thread:	[PATCH 38/49] xfs: refactor xfs_trans_reserve() interface, Dave Chinner
Next by Thread:	Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]