xfs
[Top] [All Lists]

Re: [Bisected] Corruption of root fs during git bisect of drm system han

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [Bisected] Corruption of root fs during git bisect of drm system hang
From: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
Date: Mon, 22 Jul 2013 12:47:43 +0200
Cc: Ben Myers <bpm@xxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>, Stan Hoeppner <stan@xxxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple; d=mail.ud10.udmedia.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=beta; bh=IYKjSfSXpMhm/2ld0P4mHU12CX PUVlSRBLg+vvDKwxI=; b=fkJh8Q/mnUB89sSogC8HzH3PVucc+m4OsTKR9R786N PwOO8Ol82QlhgaTGkJKBUgpVQ0bh4VT2kAAKlydequxco6yvbroC6kpfd27nDWbT 1aycjzatpiMctatksWF3+Sb9oluNwSkLBRYTM/5Av0/6EYMFj2ODrt1BDrE8c9th 0=
In-reply-to: <20130722102223.GG11674@dastard>
References: <20130713090523.GA362@x4> <20130712070721.GA359@x4> <20130715022841.GH5228@dastard> <20130715064734.GA361@x4> <20130719122235.GA360@x4> <20130720014836.GZ11674@dastard> <20130722102223.GG11674@dastard>
On 2013.07.22 at 20:22 +1000, Dave Chinner wrote:
> On Sat, Jul 20, 2013 at 11:48:36AM +1000, Dave Chinner wrote:
> > On Fri, Jul 19, 2013 at 02:22:35PM +0200, Markus Trippelsdorf wrote:
> > > On 2013.07.15 at 08:47 +0200, Markus Trippelsdorf wrote:
> > > I've bisected this issue to the following commit:
> > > 
> > >  commit cca9f93a52d2ead50b5da59ca83d5f469ee4be5f
> > >  Author: Dave Chinner <dchinner@xxxxxxxxxx>
> > >  Date:   Thu Jun 27 16:04:49 2013 +1000
> > > 
> > >      xfs: don't do IO when creating an new inode
> > >          
> > > Reverting this commit on top of the Linus tree "solves" all problems for
> > > me. IOW I no longer loose my KDE and LibreOffice config files during a
> > > crash. Log recovery now works fine and xfs_repair shows no issues.
> > 
> > Thanks for bisecting this, Marcus.
> > 
> > I'll admit, right now it doesn't make a lot of sense to me - I don't
> > immediately see a connection between not reading an inode during the
> > create phase and unlinked list and directory corruption after a
> > crash. But now you've identified a change that might be the cause,
> > I have an avenue of investigation I can follow.
> > 
> > Indeed, in the time I've taken to write this mail I've thought of
> > 2-3 possible causes that I need to investigate....
> 
> Hi Markus, can you test the patch I just posted to the list titled
> "xfs: di_flushiter considered harmful" and see if it fixes your
> problem? Archive link here:
> 
> http://oss.sgi.com/pipermail/xfs/2013-July/028331.html

Unfortunately no. I still get the same corruption with this patch
applied.

(It's embarrassing to mention, but please add:
Reported-by: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
to the next iteration of this patch.
Thanks.)

-- 
Markus

<Prev in Thread] Current Thread [Next in Thread>