xfs
[Top] [All Lists]

Re: [PATCH] xfstests: skip generic/192 if noatime is set

To: David Sterba <dsterba@xxxxxxx>
Subject: Re: [PATCH] xfstests: skip generic/192 if noatime is set
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 19 Jul 2013 15:50:48 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1372860005-1016-1-git-send-email-dsterba@xxxxxxx>
References: <1372860005-1016-1-git-send-email-dsterba@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jul 03, 2013 at 04:00:05PM +0200, David Sterba wrote:
> Test generic/192 fails if noatime is set
> 
> generic/192
>     -delta1 - access time after sleep in-core: 40
>     -delta2 - access time after sleep on-disk: 40
>     +delta1 - access time after sleep in-core: 0
>     +delta2 - access time after sleep on-disk: 0
> 
> but it's pointless to test atime effects with noatime.
> 
> Signed-off-by: David Sterba <dsterba@xxxxxxx>

Looks fine.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied.  Thanks David.

-Ben

<Prev in Thread] Current Thread [Next in Thread>