xfs
[Top] [All Lists]

Re: [PATCH v4 4/7] xfs: convert kuid_t to/from uid_t for internal struct

To: Dwight Engen <dwight.engen@xxxxxxxxxx>
Subject: Re: [PATCH v4 4/7] xfs: convert kuid_t to/from uid_t for internal structures
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 19 Jul 2013 15:35:32 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130717114734.4d2ca6fb@xxxxxxxxxx>
References: <20130717114734.4d2ca6fb@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 17, 2013 at 11:47:34AM -0400, Dwight Engen wrote:
> Use uint32 from init_user_ns for xfs internal uid/gid
> representation in xfs_icdinode, xfs_dqid_t.
> 
> Signed-off-by: Dwight Engen <dwight.engen@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_inode.c    |  6 +++---
>  fs/xfs/xfs_iops.c     | 38 ++++++++++++++++++++------------------
>  fs/xfs/xfs_qm.c       | 10 +++++-----
>  fs/xfs/xfs_quota.h    | 11 ++++++-----
>  fs/xfs/xfs_symlink.c  |  6 ++++--
>  fs/xfs/xfs_vnodeops.c |  8 +++++---
>  6 files changed, 43 insertions(+), 36 deletions(-)

Looks good. It's clear now that here is a difference between what
is held in the VFS inode and the XFS inode core....

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>