xfs
[Top] [All Lists]

Re: [PATCH v4 1/7] xfs: create wrappers for converting kuid_t to/from ui

To: Dwight Engen <dwight.engen@xxxxxxxxxx>
Subject: Re: [PATCH v4 1/7] xfs: create wrappers for converting kuid_t to/from uid_t
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 19 Jul 2013 15:19:33 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130717114714.256c828d@xxxxxxxxxx>
References: <20130717114714.256c828d@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 17, 2013 at 11:47:14AM -0400, Dwight Engen wrote:
> Signed-off-by: Dwight Engen <dwight.engen@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_linux.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index 800f896..761e4c0 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -159,6 +159,32 @@
>  #define MAX(a,b)     (max(a,b))
>  #define howmany(x, y)        (((x)+((y)-1))/(y))
>  
> +/* Kernel uid/gid conversion. These are used to convert to/from the on disk
> + * uid_t/gid_t types to the kuid_t/kgid_t types that the kernel uses 
> internally.
> + * The conversion here is type only, the value will remain the same since we
> + * are converting to the init_user_ns. The uid is later mapped to a 
> particular
> + * user namespace value when crossing the kernel/user boundary.
> + */
> +static inline __uint32_t xfs_kuid_to_uid(kuid_t uid)
> +{
> +     return from_kuid(&init_user_ns, uid);
> +}
> +
> +static inline kuid_t xfs_uid_to_kuid(__uint32_t uid)
> +{
> +     return make_kuid(&init_user_ns, uid);
> +}
> +
> +static inline __uint32_t xfs_kgid_to_gid(kgid_t gid)
> +{
> +     return from_kgid(&init_user_ns, gid);
> +}
> +
> +static inline kgid_t xfs_gid_to_kgid(__uint32_t gid)
> +{
> +     return make_kgid(&init_user_ns, gid);
> +}

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>