| To: | Ben Myers <bpm@xxxxxxx> |
|---|---|
| Subject: | Re: splice vs execve lockdep trace. |
| From: | Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> |
| Date: | Wed, 17 Jul 2013 17:17:36 -0700 |
| Cc: | Dave Chinner <david@xxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Dave Jones <davej@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=pl4t2N5ID5xhwLOCMroVxJw+B1CISeBy/4Xzrb4dWcs=; b=xhPfX4BfnCWKfcoA4Sl7xWS+ifwI7N/OL0SP5Nao7TUKO8BDXr9xer75PCbaOrQ4qr sTUFY1ZuQWvVM6enTTz44RT9oAq68K7tHJSk7I3zsxr5kDilmK0qJyWxBUVgIaUZWInO 5GgSNwU+x2TCoBONA2aFPAAficAozGdRZB88OqcrjndNE3gzAquHVkVIEQVeNTfUv51z OUoYSPClH4OHKRzvfzPr4zJUdJjudDUitWQcopr0SxjoVW0WryrFb1yHij0xtKayfGde 83F07vMj0gWdgSzxO4KIvUhrUl//24IvcrMWwQt9Jjg/Jcu/DuWQr0z2XG3FIuwefpum zGdw== |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=pl4t2N5ID5xhwLOCMroVxJw+B1CISeBy/4Xzrb4dWcs=; b=OicBCBP4WZh7bjBiUC8J4BD0zVpyC78cJ4Y8G3p+r+Pg6JnM+1los0lp+pC2rGRZGI GGZqgGAuIlSI5DzE6ADYvss0n1keyTuLaey46XvPZX3L4CEhvv6ECTOTSP27fe/KPUIK jUxF25sXcXjVEVZCCJJYNTbnHhjbKzgzIH3Wc= |
| In-reply-to: | <20130717234049.GC3572@xxxxxxx> |
| References: | <CA+55aFxiGXht8+Dox=C2ezYYf1yMaLAzMYr40j=+peP8j5Ha6w@xxxxxxxxxxxxxx> <20130716060351.GE11674@dastard> <20130716193332.GB3572@xxxxxxx> <CA+55aFzTBUKStdZu1GhKoiYc2knybhiaUFr2By98QYew_STE=A@xxxxxxxxxxxxxx> <20130716204335.GH11674@dastard> <CA+55aFwHMQd-VDeTDh-gm3jyj+5+FSoAHOeU47mwU-mKtEj9RQ@xxxxxxxxxxxxxx> <20130717040616.GI11674@dastard> <CA+55aFz5xw9Qi9Q6mwoCSud5eQh5u-QZ-xrY+TqgZPoKOgn6ew@xxxxxxxxxxxxxx> <20130717055103.GK11674@dastard> <CA+55aFxdqzMY5VJoYaLmL=+=f2s1cbHHV-TjC3=taXpF-xov1w@xxxxxxxxxxxxxx> <20130717234049.GC3572@xxxxxxx> |
| Sender: | linus971@xxxxxxxxx |
On Wed, Jul 17, 2013 at 4:40 PM, Ben Myers <bpm@xxxxxxx> wrote:
>>
>> We're still talking at cross purposes then.
>>
>> How the hell do you handle mmap() and page faulting?
>
> __xfs_get_blocks serializes access to the block map with the i_lock on the
> xfs_inode. This appears to be racy with respect to hole punching.
Would it be possible to just make __xfs_get_blocks get the i_iolock
(non-exclusively)?
Or, alternatively, do it in the readpage() function?
That was what I thought you did anyway. Exactly because of the whole
page faulting issue.
Linus
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: splice vs execve lockdep trace., Ben Myers |
|---|---|
| Next by Date: | Re: [PATCH] xfs: Fix a deadlock in xfs_log_commit_cil() code path, Dave Chinner |
| Previous by Thread: | Re: splice vs execve lockdep trace., Ben Myers |
| Next by Thread: | Re: splice vs execve lockdep trace., Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |