xfs
[Top] [All Lists]

Re: [PATCH] xfs: Fix the logic check for all quotas being turned off

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: Fix the logic check for all quotas being turned off
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 11 Jul 2013 16:41:44 -0500
Cc: XFS mailing list <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1373497236.6020.36.camel@xxxxxxxxxxxxxxxxxx>
References: <1373497236.6020.36.camel@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jul 10, 2013 at 06:00:36PM -0500, Chandra Seetharaman wrote:
> 
> During the review of seperate pquota inode patches, David noticed
> that the test to detect all quotas being turned off was
> incorrect, and hence the block was not freeing all the quota
> information.
> 
> The check made sense in Irix, but in Linux, quota is turned off
> one at a time, which makes the test invalid for Linux.
> 
> This problem existed since XFS was ported to Linux.
> 
> David suggested to fix the problem by detecting when all quotas are
> turned off by checking m_qflags.
> 
> Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

This looks ok to me. 

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>