Re: [PATCH V2] xfstests: generic/313, test sgid inheritance on subdirs

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 7/11/13 1:34 PM, Eric Sandeen wrote:
> On 7/11/13 1:28 PM, Carlos Maiolino wrote:

...

>> Just a matter of information:
>>
>> From coreutils:
>>
>> commit b3677e5e383103bf1764b2c8a9329b1c17934b24
>> Author: Jim Meyering <meyering@xxxxxxxxxx>
>> Date:   Wed Apr 2 22:26:45 2008 +0200
>>
>>     ls: use '.' (not +) as SELinux-only alt. access flag in ls -l output
>>
>>
>>
>> So, this test is selinux dependent, it will provide different outputs whether
>> the system has selinux enabled or not.
>>
>> Since the test itself creates their own directories, checking if the selinux 
>> is
>> enabled or not and checking the proper output depending on selinux activity
>> should avoid false positives on this test. I.e. if the selinux is enabled, 
>> the
>> `ls -l` output will print the 'dot' at the end of the permissions, otherwise,
>> nothing will be printed and Eric's test will pass without problem.
> 
> Hm, I thought we always mounted with a global selinux context, and therefore
> wouldn't get these differences (i.e. no on-disk selinux attrs should be 
> created)


Ok, somehow it really is mounted w/o the context when the test executes.
I'm not sure why yet, but fixing that *should* fix the problem, I think.

-Eric