xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: generic/313, test sgid inheritance on subdirs

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH V2] xfstests: generic/313, test sgid inheritance on subdirs
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Thu, 11 Jul 2013 14:53:16 -0300
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130708215151.GK20932@xxxxxxx>
References: <51A68175.9020202@xxxxxxxxxx> <51A7B03E.2080909@xxxxxxxxxxx> <20130612192320.GA12955@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20130708215151.GK20932@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 08, 2013 at 04:51:51PM -0500, Ben Myers wrote:
> Hey Carlos & Eric,
> 
> On Wed, Jun 12, 2013 at 04:23:20PM -0300, Carlos Maiolino wrote:
> > I'm personally working on this bug with Eric, and the test properly trigger 
> > the
> > bug on 100% of the test runs, but, it should also ensure that
> > `irix_sgid_inherit` sysctl is set to 0, if not, the test will fail.
> > 
> > follow is a suggestion for a better changelog:
> > 
> > Tests if subdirectories created on the filesystem will properly inherit 
> > sgid bit
> > when this is set on the parent directory, once the process has the properly
> > permissions to create a subdirectory, this, should inherit parent's sgid 
> > bit if
> > this is set and irix_sgid_inherit sysctl is disabled.
> 
> I applied this and tested with Carlos's latest patch:
> 
> generic/313      - output mismatch (see 
> /root/xfstests/results/generic/313.out.bad)
>     --- tests/generic/313.out   2013-07-08 16:27:41.787710646 -0500
>     +++ /root/xfstests/results/generic/313.out.bad      2013-07-08 
> 16:47:46.052683735 -0500
>     @@ -1,3 +1,3 @@
>      QA output created by 313
>     -drwxr-sr-x. TEST_DIR/313-dir/subdir
>     +drwxr-sr-x TEST_DIR/313-dir/subdir
>      drwxrwsr-x+ TEST_DIR/313-dir/subdir2
>      ...
>      (Run 'diff -u tests/generic/313.out 
> /root/xfstests/results/generic/313.out.bad' to see the entire diff)
> 
> Looks like there could be a problem with ls?  Have you seen that?
> 
> Thanks,
> Ben
> 
Actually I don't think this is a problem, but the way newer `ls` versions are
displaying the object permissions (the 'dot' at the end of the permissions,
indicating there are no extra attributes).

I'm going to take a look on what's going on, but I still believe it's just a
matter of add the 'dot' to the xfstests correct output.

I had this same problem when testing my patch and needed to fix it locally, but
missed to warn you guys, my apologies

-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>