xfs
[Top] [All Lists]

Re: [PATCH v10 08/11] xfs: Add pquota fields where gquota is used.

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH v10 08/11] xfs: Add pquota fields where gquota is used.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 11 Jul 2013 11:23:35 +1000
Cc: Ben Myers <bpm@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1373492798.6020.34.camel@xxxxxxxxxxxxxxxxxx>
References: <1372371914-11370-1-git-send-email-sekharan@xxxxxxxxxx> <1372371914-11370-9-git-send-email-sekharan@xxxxxxxxxx> <20130710213907.GZ20932@xxxxxxx> <1373492798.6020.34.camel@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 10, 2013 at 04:46:38PM -0500, Chandra Seetharaman wrote:
> > > @@ -1160,13 +1160,13 @@ xfs_ioctl_setattr(
> > >    */
> > >   xfs_qm_dqrele(olddquot);
> > >   xfs_qm_dqrele(udqp);
> > > - xfs_qm_dqrele(gdqp);
> > > + xfs_qm_dqrele(pdqp);
> > >  
> > >   return code;
> > >  
> > >   error_return:
> > >   xfs_qm_dqrele(udqp);
> > > - xfs_qm_dqrele(gdqp);
> > > + xfs_qm_dqrele(pdqp);
> > >   xfs_trans_cancel(tp, 0);
> > >   if (lock_flags)
> > >           xfs_iunlock(ip, lock_flags);
> > 
> > Here in xfs_ioctl_setattr, I'm not clear on why we're messing with the user
> > dquot at all.  Could it be removed entirely?  A change in project id doesn't
> > effect user quota, right?
> > 
> > Maybe that's an idea for a separate patch.
> 
> I will look into that after these get in :)

The user dquot may have group and/or project dquot hints attached to
it. Therefore if we are changing project quota and user quotas are
enabled, then we may have to remove the hint from the user dquot
that points to the old project dquot....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>