xfs
[Top] [All Lists]

Re: [PATCH v2] mkfs: add missing noalign suboption information

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH v2] mkfs: add missing noalign suboption information
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 10 Jul 2013 10:26:11 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1373469280-12617-1-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1373469280-12617-1-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
On 7/10/13 10:14 AM, Carlos Maiolino wrote:
> Adds to the mkfs man page, information about noalign mkfs option which is
> missing until now.
> 
> Changelog:
> 
>       V2:
>          -rephase noalign data-section option
>          -add noalign realtime device option
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> ---
>  man/man8/mkfs.xfs.8 | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index 04c19b4..61122f0 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -244,6 +244,11 @@ will automatically query the logical volume for 
> appropriate
>  and
>  .B swidth
>  values.
> +.TP
> +.BI noalign
> +This option disables automatic geometry detection and creates the filesystem
> +without stripe geometry alignment even if the underlying storage device 
> provides
> +this information.
>  .RE
>  .TP
>  .B \-f
> @@ -695,6 +700,10 @@ This is used to specify the size of the real-time 
> section.
>  This suboption is only needed if the real-time section of the
>  filesystem should occupy less space than the size of the partition
>  or logical volume containing the section.
> +.TP
> +.BI noalign
> +This option disables stripe size detection, enforcing a realtime device with 
> no
> +stripe geometry.

It's ok, but why change the wording vs. the data section?  i.e. I'd do:

> +This option disables automatic geometry detection and creates the realtime 
> subvolume
> +without stripe geometry alignment even if the underlying storage device 
> provides
> +this information.

But *shrug* it's not that big a deal.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>, or you can send V3 (or 
whatever) :)

-Eric

>  .RE
>  .TP
>  .BI \-s " sector_size"
> 

<Prev in Thread] Current Thread [Next in Thread>