xfs
[Top] [All Lists]

Fwd: Re: [PATCH 13/15] xfs: remove local fork format handling from xfs_b

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: Fwd: Re: [PATCH 13/15] xfs: remove local fork format handling from xfs_bmapi_write()
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 09 Jul 2013 15:39:10 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51CCF071.9000304@xxxxxxx>
References: <51CCF071.9000304@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
Sorry, I did not add the mailing list.

--Mark.

-------- Original Message --------
Subject: Re: [PATCH 13/15] xfs: remove local fork format handling from xfs_bmapi_write()
Date: Thu, 27 Jun 2013 21:09:53 -0500
From: Mark Tinguely <tinguely@xxxxxxx>
To: Dave Chinner <david@xxxxxxxxxxxxx>

On 06/27/13 01:04, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The conversion from local format to extent format requires
interpretation of the data in the fork being converted, so it cannot
be done in a generic way. It is up to the caller to convert the fork
format to extent format before calling into xfs_bmapi_write() so
format conversion can be done correctly.

The code in xfs_bmapi_write() to convert the format is used
implicitly by the attribute and directory code, but they
specifically zero the fork size so that the conversion does not do
any allocation or manipulation. Move this conversion into the
shortform to leaf functions for the dir/attr code so the conversions
are explicitly controlled by all callers.

Now we can remove the conversion code in xfs_bmapi_write.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Fwd: Re: [PATCH 13/15] xfs: remove local fork format handling from xfs_bmapi_write(), Mark Tinguely <=