xfs
[Top] [All Lists]

Re: [PATCH] xfs: clean up unused codes at xfs_bulkstat()

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: clean up unused codes at xfs_bulkstat()
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 9 Jul 2013 15:37:20 -0500
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130702103046.GD14996@dastard>
References: <51D18964.2030708@xxxxxxxxxx> <20130702103046.GD14996@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Jul 02, 2013 at 08:30:46PM +1000, Dave Chinner wrote:
> On Mon, Jul 01, 2013 at 09:51:32PM +0800, Jeff Liu wrote:
> > From: Jie Liu <jeff.liu@xxxxxxxxxx>
> > 
> > There are some unused codes at xfs_bulkstat():
> > 
> > - Variable bp is defined to point to the on-disk inode cluster
> >   buffer, but it proved to be of no practical help.
> > 
> > - We process the chunks of good inodes which were fetched by iterating
> >   btree records from an AG.  When processing inodes from each chunk,
> >   the code recomputing agbno if run into the first inode of a cluster,
> >   however, the agbno is not being used thereafter.
> > 
> > This patch tries to clean up those things.
> > 
> > Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Applied.

<Prev in Thread] Current Thread [Next in Thread>