xfs
[Top] [All Lists]

[PATCH] xfstests: exit out if _scratch_mount fails

To: <xfs@xxxxxxxxxxx>, <linxu-btrfs@xxxxxxxxxxxxxxx>
Subject: [PATCH] xfstests: exit out if _scratch_mount fails
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Tue, 9 Jul 2013 15:07:27 -0400
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1373396849; bh=BLcQljd7pG6grkiKLRoehHoUQsnZ2O/2IgtU2DFltUA=; h=From:To:Subject:Date; b=ciP55KhPYKxJNEqNeWszQ1n/OLWXMSiy5M2UnsTdyGHz2oauPMWfhnWtiGz6kdC6i gG8I3l/upZSUoRn0CMI+fHydT3TvxXDWypdgaioqF17FMflmM/HIzT2HNbUa68qn9f VJ/Wt+LdMoGfwDn4ybLjaxqjySliBPych9ZmoXFg=
I test some of the different mkfs options for btrfs, one set doesn't work
properly with small file systems, so the fs won't mount.  This is fine from a
btrfs point of view, but tests that fail to mount the scratch fs will run
anyway, so if it's a "fill the fs" sort of test this will wreak havoc.  To fix
this just error out of _scratch_mount fails.  Thanks,

Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
---
 common/rc |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/common/rc b/common/rc
index 4de1329..f11699f 100644
--- a/common/rc
+++ b/common/rc
@@ -276,6 +276,10 @@ _scratch_mount_options()
 _scratch_mount()
 {
     _mount -t $FSTYP `_scratch_mount_options $*`
+    if [ $? -ne 0 ]; then
+       echo "mount failed"
+       exit 1
+    fi
 }
 
 _scratch_unmount()
-- 
1.7.7.6

<Prev in Thread] Current Thread [Next in Thread>