xfs
[Top] [All Lists]

[PATCH] xfstests: skip generic/192 if noatime is set

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfstests: skip generic/192 if noatime is set
From: David Sterba <dsterba@xxxxxxx>
Date: Wed, 3 Jul 2013 16:00:05 +0200
Cc: David Sterba <dsterba@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Test generic/192 fails if noatime is set

generic/192
    -delta1 - access time after sleep in-core: 40
    -delta2 - access time after sleep on-disk: 40
    +delta1 - access time after sleep in-core: 0
    +delta2 - access time after sleep on-disk: 0

but it's pointless to test atime effects with noatime.

Signed-off-by: David Sterba <dsterba@xxxxxxx>
---
 tests/generic/192 | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/generic/192 b/tests/generic/192
index a40c121..2b4e41c 100755
--- a/tests/generic/192
+++ b/tests/generic/192
@@ -38,6 +38,13 @@ _access_time()
        stat --format=%X $1
 }
 
+is_noatime_set() {
+       case "$MOUNT_OPTIONS" in
+               *noatime*) return 0;;
+       esac
+       return 1
+}
+
 # get standard environment, filters and checks
 . ./common/rc
 . ./common/filter
@@ -52,6 +59,10 @@ _supported_os Linux
 #delay=45
 delay=40
 
+if is_noatime_set; then
+       _notrun "this test makes no sense with noatime"
+fi
+
 testfile=$TEST_DIR/testfile
 rm -f $testfile
 rm -f $seqres.full
-- 
1.8.2

<Prev in Thread] Current Thread [Next in Thread>