xfs
[Top] [All Lists]

Re: [PATCH] xfs: clean up unused codes at xfs_bulkstat()

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: clean up unused codes at xfs_bulkstat()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 2 Jul 2013 20:30:46 +1000
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51D18964.2030708@xxxxxxxxxx>
References: <51D18964.2030708@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 01, 2013 at 09:51:32PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> There are some unused codes at xfs_bulkstat():
> 
> - Variable bp is defined to point to the on-disk inode cluster
>   buffer, but it proved to be of no practical help.
> 
> - We process the chunks of good inodes which were fetched by iterating
>   btree records from an AG.  When processing inodes from each chunk,
>   the code recomputing agbno if run into the first inode of a cluster,
>   however, the agbno is not being used thereafter.
> 
> This patch tries to clean up those things.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>