Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data struct

To:	Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject:	Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo
From:	Ben Myers <bpm@xxxxxxx>
Date:	Fri, 28 Jun 2013 11:30:58 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1372371914-11370-6-git-send-email-sekharan@xxxxxxxxxx>
References:	<1372371914-11370-1-git-send-email-sekharan@xxxxxxxxxx> <1372371914-11370-6-git-send-email-sekharan@xxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

Hey Chandra,

On Thu, Jun 27, 2013 at 05:25:08PM -0500, Chandra Seetharaman wrote:
> In preparation for combined pquota/gquota support, do some
> whitespace cleanups.
> 
> Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

Wow.  Putting this in a patch by itself really puts it into stark
relief.

If we pull this in we're representing that some tabs and the alignment
of the fields is more valuable than the comments?  I'm fairly certain I
don't agree that's the case...

I'm sorry for your trouble, but I think I should pass on this one.  Do
you agree?

Thanks,
        Ben

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v10 00/11] Allow pquota and gquota to be used together, Chandra Seetharaman [PATCH v10 02/11] xfs: Replace macro XFS_DQUOT_TREE with a function, Chandra Seetharaman Re: [PATCH v10 02/11] xfs: Replace macro XFS_DQUOT_TREE with a function, Ben Myers [PATCH v10 01/11] xfs: Define a new function xfs_is_quota_inode(), Chandra Seetharaman Re: [PATCH v10 01/11] xfs: Define a new function xfs_is_quota_inode(), Ben Myers [PATCH v10 04/11] xfs: Code cleanup and removal of some typedef usage, Chandra Seetharaman Re: [PATCH v10 04/11] xfs: Code cleanup and removal of some typedef usage, Ben Myers [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo, Chandra Seetharaman Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo, Ben Myers <= Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo, Chandra Seetharaman Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo, Ben Myers [PATCH v10 06/11] xfs: Change xfs_dquot_acct to be a 2-dimensional array, Chandra Seetharaman Re: [PATCH v10 06/11] xfs: Change xfs_dquot_acct to be a 2-dimensional array, Ben Myers [PATCH v10 03/11] xfs: Replace macro XFS_DQ_TO_QIP with a function, Chandra Seetharaman Re: [PATCH v10 03/11] xfs: Replace macro XFS_DQ_TO_QIP with a function, Ben Myers [PATCH v10 07/11] xfs: Remove incore use of XFS_OQUOTA_ENFD and XFS_OQUOTA_CHKD, Chandra Seetharaman Re: [PATCH v10 07/11] xfs: Remove incore use of XFS_OQUOTA_ENFD and XFS_OQUOTA_CHKD, Ben Myers [PATCH v10 09/11] xfs: Start using pquotaino from the superblock., Chandra Seetharaman Re: [PATCH v10 09/11] xfs: Start using pquotaino from the superblock., Dave Chinner

Previous by Date:	Re: [PATCH v2 RFC] userns: Convert xfs to use kuid/kgid where appropriate, Dwight Engen
Next by Date:	Re: [PATCH 01/15] xfs: update mount options documentation, Eric Sandeen
Previous by Thread:	[PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo, Chandra Seetharaman
Next by Thread:	Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo, Chandra Seetharaman
Indexes:	[Date] [Thread] [Top] [All Lists]