xfs
[Top] [All Lists]

Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data struct

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 28 Jun 2013 11:30:58 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1372371914-11370-6-git-send-email-sekharan@xxxxxxxxxx>
References: <1372371914-11370-1-git-send-email-sekharan@xxxxxxxxxx> <1372371914-11370-6-git-send-email-sekharan@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Chandra,

On Thu, Jun 27, 2013 at 05:25:08PM -0500, Chandra Seetharaman wrote:
> In preparation for combined pquota/gquota support, do some
> whitespace cleanups.
> 
> Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

Wow.  Putting this in a patch by itself really puts it into stark
relief.

If we pull this in we're representing that some tabs and the alignment
of the fields is more valuable than the comments?  I'm fairly certain I
don't agree that's the case...

I'm sorry for your trouble, but I think I should pass on this one.  Do
you agree?

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>