xfs
[Top] [All Lists]

Re: [PATCH 01/15] xfs: update mount options documentation

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 01/15] xfs: update mount options documentation
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 28 Jun 2013 12:09:12 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130627190831.GN20932@xxxxxxx>
References: <1372313099-8121-1-git-send-email-david@xxxxxxxxxxxxx> <1372313099-8121-2-git-send-email-david@xxxxxxxxxxxxx> <20130627144814.GM20932@xxxxxxx> <20130627190831.GN20932@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 27, 2013 at 02:08:31PM -0500, Ben Myers wrote:
> Hey Dave,
> 
> On Thu, Jun 27, 2013 at 09:48:14AM -0500, Ben Myers wrote:
> > On Thu, Jun 27, 2013 at 04:04:45PM +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > > 
> > > Because it's horribly out of date.
> > > 
> > > And mark various deprecated options as deprecated and give them a
> > > removal date.
> > > 
> > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > > Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
> > 
> > Regarding removal of these mount options and sysctls:  initially these all 
> > look
> > pretty reasonable but we need to be very careful here.  I've read some
> > discussions on lkml that seem to suggest that such interfaces which have 
> > been
> > exported to userspace shouldn't be removed at all.  Not that I want to keep
> > around a bunch of worn out interfaces...
> > 
> > Applied.
> 
> On second thought... Not pushed.
> 
> I'm going to hold off on pushing this one to oss for now because I'm just not
> comfortable with it yet.  I can pull this in sans the removal notices if you
> want.  Lets discuss whether the removal of deprecated mount options and 
> sysctls
> is acceptable before announcing an intention to remove them.  I'm trending no,
> but I can be flexible if this really is ok.

Mount options are perfectly fine to be removed - they've been given
deprecated warnings for quite some time now (the most recent is the
delaylog which has been doing that since 3.1 IIRC). So they are all
fine to actually remove - 12 months warning is usually considered
sufficient.

As to the sysctls - they haven't had any effect since 3.5 when the
xfsbufd was removed, so it's time to mark them deprecated so we can
remove them in a year's time. That gives anyone using them
(including distros) plenty of time to fix whatever is using them
before they get removed.

> I'm thinking of the 3.3 glusterfs and 3.8 pulseaudio reakeage.  And I would
> really like to have a nice holiday weekend. ;)

I think you're being overly paranoid here - I'm simply following the
normal deprecation protocol here....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>