| To: | Josef Bacik <jbacik@xxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch |
| From: | Zach Brown <zab@xxxxxxxxxx> |
| Date: | Wed, 26 Jun 2013 12:18:04 -0700 |
| Cc: | xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1372261768-1795-1-git-send-email-jbacik@xxxxxxxxxxxx> |
| References: | <1372261768-1795-1-git-send-email-jbacik@xxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> $SCRATCH_DEV, so anybody who wants to just use the scratch mnt with the
> scratch
> dev will fail to work because we never unmount the scratch mount.
Yeah, this is annoying.
> Fix this by
> checking to see if the scratch dev pool is mounted at scratch mnt and unmount
> it
> so we can run our test. This fixes the issue I was seeing by running
But this fix seems bonkers. Can we have _scratch_unmount unmount the
mountpoint instead of the device? That's what Eric suggested when I
whined about this a while ago.
- z
index fe6bbfc..481486a 100644
--- a/common/rc
+++ b/common/rc
@@ -280,7 +280,7 @@ _scratch_mount()
_scratch_unmount()
{
- $UMOUNT_PROG $SCRATCH_DEV
+ $UMOUNT_PROG $SCRATCH_MNT
}
_scratch_remount()
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | XFS status update for May 2013, Ben Myers |
|---|---|
| Next by Date: | Trade Only Print Partner, Color Point Printing |
| Previous by Thread: | [PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch, Josef Bacik |
| Next by Thread: | Re: [PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch, Josef Bacik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |