xfs
[Top] [All Lists]

Re: [PATCH] xfstests: aio-stress is calling pthread_join incorrectly

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: aio-stress is calling pthread_join incorrectly
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 26 Jun 2013 11:22:56 -0500
Cc: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130618231314.GC29338@dastard>
References: <51C0E5BC.6060809@xxxxxxxxxx> <20130618231314.GC29338@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jun 19, 2013 at 09:13:14AM +1000, Dave Chinner wrote:
> On Tue, Jun 18, 2013 at 05:57:00PM -0500, Dave Kleikamp wrote:
> > The retval parameter to pthread_join() is a pointer to a pointer.
> > aio-stress is passing in a pointer to an int. This can result in a bus
> > error on sparc64 when the pointer is not aligned on a 64-bit boundary.
> > Since the return value is not used, it is simplest to pass a NULL
> > pointer instead.
> > 
> > This has been fixed in the LTP source:
> > https://github.com/linux-test-project/ltp/commit/981d33aad3b33c4625b88990fbf2fad5470d47e0
> > 
> > Signed-off-by: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx>
> 
> Looks good. Thanks, Shaggy.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Applied.

<Prev in Thread] Current Thread [Next in Thread>