xfs
[Top] [All Lists]

Re: [PATCH v9 5/6] xfs: Add proper versioning support to fs_quota_stat

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH v9 5/6] xfs: Add proper versioning support to fs_quota_stat
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 26 Jun 2013 11:20:44 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1372199784.8341.102.camel@xxxxxxxxxxxxxxxxxx>
References: <1372042107-27332-1-git-send-email-sekharan@xxxxxxxxxx> <1372042107-27332-6-git-send-email-sekharan@xxxxxxxxxx> <20130625064312.GV29376@dastard> <1372199784.8341.102.camel@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 25, 2013 at 05:36:24PM -0500, Chandra Seetharaman wrote:
> On Tue, 2013-06-25 at 16:43 +1000, Dave Chinner wrote:
> > On Sun, Jun 23, 2013 at 09:48:26PM -0500, Chandra Seetharaman wrote:
> > > Added appropriate pads and code for backward compatibility.
> > > 
> > > Copied over the old version as it is different from the newer padded
> > > version.
> > > 
> > > New callers of the system call have to set the version of the data
> > > structure being passed, and kernel will fill as much data as requested.
> > 
> > Is there are test for this? i.e. that the different version
> > structures return the same information?
> 
> You want me to add it to xfstests ?

Yes, please. :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>