xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: fix make deb

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: fix make deb
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 25 Jun 2013 17:01:23 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1371526854-15761-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1371526854-15761-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Jun 18, 2013 at 01:40:53PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Commit 48212a30 ("xfsprogs: update 'make deb' to use tarball) fixed
> a bunch of problems with making the source tarball for releases.
> However, it broke the debian package builds in a way I hadn't
> noticed until I rewrote my CI system build script.
> 
> I noticed that the CI system wasn't building from a pristine
> workarea, and instead was just updating the old workarea and running
> 'make deb'. I added a 'make realclean' to remove all previous state
> from the workarea, and then 'make deb' started failing with errors
> building the tarball because po/xfsprogs.pot didn't have a build
> rule
> 
> The above commit removed the pre-build of the translations target,
> and instead made the translation build target a dependency of
> building the the tarball. Hence the lack of a build rule of the
> translations causes the source tarball build to fail.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

My systems seem not to be having this problem.  They seem to be building
xfsprogs.pot due to the dependancy through SRCDIR->SRCTAR->SRCTARINC.  Can you
post the error?

-Ben

<Prev in Thread] Current Thread [Next in Thread>