[Top] [All Lists]

Re: [PATCH] xfstests: fsync-tester: fix pwrite() return check and disabl

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fsync-tester: fix pwrite() return check and disable direct for test 19
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 25 Jun 2013 15:47:09 -0500
Cc: xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370999583-16725-1-git-send-email-jbacik@xxxxxxxxxxxx>
References: <1370999583-16725-1-git-send-email-jbacik@xxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Jun 11, 2013 at 09:13:03PM -0400, Josef Bacik wrote:
> Test 19 in direct mode was failing on xfs because it was not actually doing 
> the
> write because the writes were not sectorsize aligned.  This test is to test
> btrfs's inline extent fsync()ing so the writes won't be sectorsize aligned, 
> and
> inline extents will fall back to buffered anyway so direct mode is meaningless
> for this test.  So just check if we are test 19 and disable direct mode so we
> don't have to change the golden output.  Also change test_five() to compare
> against a ssize_t instead of a size_t since apparently comparing against 
> size_t
> makes it cast the return value of pwrite() to size_t which screws up the error
> case, so instead of seeing the pwrite() error on xfs which would have 
> explained
> this all it appeared as if it was succeeding and screwing up the fsync(), 
> which
> unfortunately wasted a bit of Daves time.  This patch should fix all this up.
> Thanks,
> Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>